fix: replace unstable Rust features with stable alternatives - #18
Closed
bordeux wants to merge 4 commits into
Closed
fix: replace unstable Rust features with stable alternatives#18bordeux wants to merge 4 commits into
bordeux wants to merge 4 commits into
Conversation
- Replace let-chains (if let && let) with nested if let in array.rs - Replace is_multiple_of() with modulo operator in statistics.rs These features require nightly Rust but Docker builds use stable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Extract CLI logic into run() function in lib.rs that accepts args - Simplify main.rs to minimal boilerplate (9 lines) - Add 20 comprehensive tests for the run() function covering: - Template rendering, output files, validation flags - Error handling, CLI argument parsing - Trust mode, includes, and combined flags This enables unit testing of the main entry point logic without needing to spawn separate processes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 88.76% 88.94% +0.17%
==========================================
Files 30 31 +1
Lines 1914 1917 +3
==========================================
+ Hits 1699 1705 +6
+ Misses 215 212 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add #[allow(...)] attributes to suppress clippy suggestions for unstable features (let-chains, is_multiple_of) that would break Docker builds using stable Rust. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Handle different error messages between Unix ("No such file") and
Windows ("cannot find") for missing file errors.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These features require nightly Rust but Docker builds use stable.